Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service discovery query filtering #1337

Merged
merged 5 commits into from
Aug 16, 2022
Merged

service discovery query filtering #1337

merged 5 commits into from
Aug 16, 2022

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented Aug 15, 2022

Changes:

  • apply version and country filter for service discovery queries - skywire-cli vpn list

How to test this PR:

First, run a visor
Note that query filtering is only currently implemented on the test deployment

git checkout feature/query-filtering
make run-source-test

query the service discovery for available vpn servers

skywire-cli vpn list
skywire-cli vpn list -v 1.0.1
skywire-cli vpn list -c DE
skywire-cli vpn list -n

@0pcom 0pcom requested a review from mrpalide August 15, 2022 01:15
jdknives
jdknives approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jdknives jdknives merged commit 7367534 into develop Aug 16, 2022
@jdknives jdknives deleted the feature/query-filtering branch August 16, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

@mrpalide mrpalide Awaiting requested review from mrpalide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0pcom @jdknives @mrpalide